Skip to content

Fix initial scope handling #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix initial scope handling #3837

merged 1 commit into from
Dec 3, 2024

Conversation

@sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Dec 2, 2024 •
edited
Loading

Instead of relying on fallback behaviour, it makes sense to populate the scopes on the first context during init.

This also fixes breadcrumb leakage between httplib and subprocess tests.

@codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

❌ 415 Tests Failed:

Tests completed Failed Passed Skipped
19535 415 19120 4433
View the top 3 failed tests by shortest run time 
tests.test_scope test_get_current_scope_tags
Stack Traces | 0.001s run time 
tests/test_scope.py:343: in test_get_current_scope_tags
    assert scope1.client.__class__ == NonRecordingClient
E   AttributeError: client
tests.test_scope test_get_current_scope_tags
Stack Traces | 0.001s run time 
tests/test_scope.py:343: in test_get_current_scope_tags
    assert scope1.client.__class__ == NonRecordingClient
E   AttributeError: 'PotelScope' object has no attribute 'client'
tests.test_scope test_get_current_scope_tags
Stack Traces | 0.001s run time 
tests/test_scope.py:343: in test_get_current_scope_tags
    assert scope1.client.__class__ == NonRecordingClient
E   AttributeError: 'PotelScope' object has no attribute 'client'

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@sl0thentr0py sl0thentr0py merged commit 6e1b1cb into potel-base Dec 3, 2024
50 of 125 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/fix-scope-resetting branch December 3, 2024 13:43
@sl0thentr0py sl0thentr0py mentioned this pull request Dec 3, 2024
Closed
@BYK BYK mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sl0thentr0py @sentrivana